Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Housekeeping] Checksum grpc_health_probe #2504

Closed
2 tasks done
honnix opened this issue May 17, 2022 · 0 comments · Fixed by flyteorg/flyteadmin#425
Closed
2 tasks done

[Housekeeping] Checksum grpc_health_probe #2504

honnix opened this issue May 17, 2022 · 0 comments · Fixed by flyteorg/flyteadmin#425
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Milestone
1.0.2

Comments

@honnix
Copy link
Member

honnix commented May 17, 2022

Describe the issue

In flyteadmin Dockerfile we download grpc_health_probe but not applying checksum step, which is not so nice from a security perspective.

What if we do not do this?

Potential security risk.

Related component(s)

flyteadmin

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@honnix honnix added the housekeeping Issues that help maintain flyte and keep it tech-debt free label May 17, 2022
@honnix honnix mentioned this issue May 17, 2022
Merged
8 tasks
@pmahindrakar-oss pmahindrakar-oss added this to the 1.0.2 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Milestone
1.0.2
Development

Successfully merging a pull request may close this issue.

Checksum grpc_health_probe honnix/flyteadmin
2 participants
@honnix @pmahindrakar-oss