Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add information about behaviors of resource defaults and limits #2513

Open
2 tasks done
Tracked by #5783
marc-union opened this issue May 19, 2022 · 6 comments
Open
2 tasks done
Tracked by #5783
Labels
documentation Improvements or additions to documentation hacktoberfest

Comments

@marc-union
Copy link
Contributor

marc-union commented May 19, 2022

Description

We need clearer documentation about how Flyte sets resource defaults and limits.

From @katrogan :

Platform defaults are the defaults when no task level requests/limits are set.
If only one task level request/limit is set AND that request is under the platform limit both values will be set to whichever value was set in the task.
If only one task level request/limit is set AND that request is over the platform limit the unset value is set to the platform limit.

For full details, see the Slack thread below.

References:

https://flyte-org.slack.com/archives/C03CY9S9MFE/p1652970945750369

https://docs.flyte.org/en/latest/concepts/admin.html#task-resource-defaults

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@marc-union marc-union added documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers labels May 19, 2022
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Sep 3, 2023
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 11, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@kumare3
Copy link
Contributor

kumare3 commented Dec 22, 2023

the entire config system is getting overhauled. cc @katrogan ?

@kumare3 kumare3 removed untriaged This issues has not yet been looked at by the Maintainers stale labels Dec 22, 2023
@katrogan
Copy link
Contributor

only a proposal for now https://github.com/flyteorg/flyte/blob/master/rfc/system/3749-sane-overridable-defaults.md

but this issue is specifically for explaining what the config options mean (there is confusion between requests and defaults)

Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Sep 18, 2024
@davidmirror-ops
Copy link
Contributor

Commenting to keep it open as this is still unresolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hacktoberfest
Projects
None yet
Development

No branches or pull requests

5 participants