Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Feature] Validate input types in LaunchForm #2732

Closed
2 tasks done
hank-stripe opened this issue Jul 29, 2022 · 1 comment · Fixed by flyteorg/flyteconsole#557
Closed
2 tasks done

[UI Feature] Validate input types in LaunchForm #2732

hank-stripe opened this issue Jul 29, 2022 · 1 comment · Fixed by flyteorg/flyteconsole#557
Assignees
Labels
enhancement New feature or request ui Admin console user interface

Comments

@hank-stripe
Copy link

Motivation: Why do you think this is important?

Currently, the "Launch" button remains enabled, and submitting the form does nothing, when attempting to launch a workflow/task with an input that does not conform to the specified type. This is a confusing experience.

Goal: What should the final outcome look like, ideally?

When a required input is filled with a value that is invalid as per the specified type, then:

  1. The "Launch" button should be disabled;
  2. When the focus is not on the input field, a validation error message should be displayed above/below the input field.

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@hank-stripe hank-stripe added enhancement New feature or request ui Admin console user interface untriaged This issues has not yet been looked at by the Maintainers labels Jul 29, 2022
@welcome
Copy link

welcome bot commented Jul 29, 2022

Thank you for opening your first issue here! 🛠

@olga-union olga-union removed the untriaged This issues has not yet been looked at by the Maintainers label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui Admin console user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants