Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Support union and structured data set types in flytectl #3094

Closed
2 tasks done
pmahindrakar-oss opened this issue Nov 23, 2022 · 0 comments · Fixed by flyteorg/flyteidl#401
Closed
2 tasks done
Labels
bug Something isn't working flytectl Issues related to flytectl -Flytes CLI untriaged This issues has not yet been looked at by the Maintainers
Milestone

Comments

@pmahindrakar-oss
Copy link
Contributor

Describe the bug

Currently flytectl doesn't support creating /extracting union types and hence is not able to creation executions for tasks which utilize these types.

Add support for these in the following files and consume the updated idl in flytectl
https://github.com/flyteorg/flyteidl/blob/master/clients/go/coreutils/literals.go
https://github.com/flyteorg/flyteidl/blob/master/clients/go/coreutils/extract_literal.go

And test it by creating an execution which involves these types from flytectl

Expected behavior

flytectl should be able to launch executions involving tasks with union and structured data set

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@pmahindrakar-oss pmahindrakar-oss added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Nov 23, 2022
@pmahindrakar-oss pmahindrakar-oss added this to the 1.3.0 milestone Nov 23, 2022
@eapolinario eapolinario added the flytectl Issues related to flytectl -Flytes CLI label Dec 2, 2022
@cosmicBboy cosmicBboy changed the title [BUG] Support union and structured data set types [BUG] Support union and structured data set types in flytectl Dec 21, 2022
@cosmicBboy cosmicBboy modified the milestones: 1.3.0, 2023 Q1 Backlog Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytectl Issues related to flytectl -Flytes CLI untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants