Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Kafka Authentication #3220

Closed
2 tasks done
pingsutw opened this issue Jan 9, 2023 · 3 comments · Fixed by #5814
Closed
2 tasks done

[Core feature] Kafka Authentication #3220

pingsutw opened this issue Jan 9, 2023 · 3 comments · Fixed by #5814
Assignees
Labels
enhancement New feature or request flyteadmin Issue for FlyteAdmin Service

Comments

@pingsutw
Copy link
Member

pingsutw commented Jan 9, 2023

Motivation: Why do you think this is important?

In flyteadmin, we send a cloud event to Kafka. However, we don't have any authentication for Kafka right now. we should expose auth config, use Sarama api to read the config, and send the request to Kafka.

Goal: What should the final outcome look like, ideally?

CloudEvent Config

cloudevents:
    enable: true
    kafka:
      brokers: <kafka_ip>
      version:  1.2.1
      security_ protocol: SASL_SSL
      sasl_config: <config for SASL>

Describe alternatives you've considered

NA

Propose: Link/Inline OR Additional context

Slack Thread:

Authentication Methods Overview

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@pingsutw pingsutw added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers flyteadmin Issue for FlyteAdmin Service and removed untriaged This issues has not yet been looked at by the Maintainers labels Jan 9, 2023
@pingsutw
Copy link
Member Author

pingsutw commented Jan 9, 2023

cc @eapolinario

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Oct 7, 2023
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 15, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 4, 2023
@Sovietaced Sovietaced self-assigned this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flyteadmin Issue for FlyteAdmin Service
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants