Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Start controller-runtime manager in single binary even if webhook is disabled #3546

Closed
2 tasks done
hamersaw opened this issue Mar 28, 2023 · 0 comments · Fixed by #3547
Closed
2 tasks done
Assignees
Labels
bug Something isn't working
Milestone

Comments

@hamersaw
Copy link
Contributor

Describe the bug

Currently the single binary only starts the controller-runtime manager if the propeller webhook is enabled. This means in the case where webhook is disabled propeller is unable to be notified of k8s resource updates and in turn has much worse performance in workflow evaluations because it only evaluates workflows using the reeval duration.

Expected behavior

The controller-runtime manager should be started in single binary even if the propeller webhook is disabled.

Additional context to reproduce

Disable the propeller webhook in single binary using the disableWebhook configuration option and start single binary.

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@hamersaw hamersaw added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers and removed untriaged This issues has not yet been looked at by the Maintainers labels Mar 28, 2023
@hamersaw hamersaw self-assigned this Mar 28, 2023
@hamersaw hamersaw added this to the 1.6.0 milestone Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant