Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [flytekit-bug] pyflyte backfill does not work with custom kickoff time arguments #3599

Closed
2 tasks done
kumare3 opened this issue Apr 16, 2023 · 0 comments
Closed
2 tasks done
Assignees
Labels
bug Something isn't working flytekit FlyteKit Python related issue

Comments

@kumare3
Copy link
Contributor

kumare3 commented Apr 16, 2023

Describe the bug

For an example like this

from datetime import datetime
from flytekit import task, workflow, LaunchPlan, CronSchedule

@task
def tk(k: datetime) -> str:
  return str(k)


@workflow
def example_workflow(kickoff_time: datetime) -> str:
	return tk(k=kickoff_time)


example_launch_plan = LaunchPlan.get_or_create(
    name="example_schedule",
    workflow=example_workflow,
    schedule=CronSchedule(
        schedule="*/5 * * * *",  # Following schedule runs every min
        kickoff_time_input_arg="kickoff_time", # macro magic
    ),
)

OR

from datetime import datetime
from flytekit import task, workflow, LaunchPlan, CronSchedule

@task
def tk2() -> str:
  return "Hello"


@workflow
def example_workflow2() -> str:
	return tk2()


example_launch_plan = LaunchPlan.get_or_create(
    name="example_schedule2",
    workflow=example_workflow2,
    schedule=CronSchedule(
        schedule="*/5 * * * *",  # Following schedule runs every min
    ),
)

Where the kickoff time arguments are either present or absent.

Expected behavior

It should work in either case

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@kumare3 kumare3 added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Apr 16, 2023
@eapolinario eapolinario added flytekit FlyteKit Python related issue and removed untriaged This issues has not yet been looked at by the Maintainers labels Apr 21, 2023
@kumare3 kumare3 closed this as completed Apr 24, 2023
@kumare3 kumare3 self-assigned this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue
Projects
None yet
Development

No branches or pull requests

2 participants