[BUG] underscore not allowed for node_name in with_overrides

[Nan2018]

Describe the bug

overriding node_name with a name containing underscore causes failure when registering the workflow

Expected behavior

node names containing underscore should work

Additional context to reproduce

@flytekit.task
def task1(x: int) -> str:
    return str(x)

@flytekit.task
def task2(x: str) -> str:
    return x


@flytekit.workflow
def baby_training_wf() -> str:
    t1 = task1(x=3).with_overrides(node_name='t_1')
    return task2(x=t1).with_overrides(node_name='t_2')

registering the above workflow causes:

Failed with Exception: Reason: SYSTEM:Unknown
RPC Failed, with Status: StatusCode.INTERNAL
        details: failed to compile workflow for [resource_type:WORKFLOW project:"flytesnacks" domain:"development" name:"tmp.workflow.baby_training_wf" version:"yXlTbWXJo4nsbhCWJe5PGw==" ] with err failed to compile workflow with err Collected Errors: 4
        Error 0: Code: NodeReferenceNotFound, Node Id: t_1, Description: Referenced node [t_1] not found.
        Error 1: Code: NodeReferenceNotFound, Node Id: t_2, Description: Referenced node [t_2] not found.
        Error 2: Code: ParameterNotBound, Node Id: end-node, Description: Parameter not bound [o0].
        Error 3: Code: ParameterNotBound, Node Id: t-2, Description: Parameter not bound [x].

no error if replace underscore with dash as node_name='t-1' node_name='t-2'

Screenshots

No response

Are you sure this issue hasn't been raised already?

• Yes

Have you read the Code of Conduct?

• Yes