Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Spark Task Driver UI Link is broken #3623

Closed
2 tasks done
mucahitkantepe opened this issue Apr 26, 2023 · 1 comment · Fixed by flyteorg/flyteplugins#389
Closed
2 tasks done

[BUG] Spark Task Driver UI Link is broken #3623

mucahitkantepe opened this issue Apr 26, 2023 · 1 comment · Fixed by flyteorg/flyteplugins#389
Assignees
@hamersaw
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@mucahitkantepe
Copy link
Contributor

Describe the bug

The Spark Driver UI link is broken. It refers to a link like https://http/....
image

This line of code adds the additional https:// https://github.com/flyteorg/flyteplugins/blob/63e1e45de43c39d0bae7dfb973f0176a18228ecb/go/tasks/plugins/k8s/spark/spark.go#L411

Older versions of Spark Operator didn't have http section but now it does https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/blob/5f2efd4ff97e7c0bfdb726a066118d3401576730/pkg/controller/sparkapplication/sparkui.go#L57

Expected behavior

The link should not contain duplicated http section

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@mucahitkantepe mucahitkantepe added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Apr 26, 2023
@welcome
Copy link

welcome bot commented Apr 26, 2023

Thank you for opening your first issue here! 🛠

@mucahitkantepe mucahitkantepe mentioned this issue Apr 26, 2023
Closed
@eapolinario eapolinario removed the untriaged This issues has not yet been looked at by the Maintainers label Apr 28, 2023
@eapolinario eapolinario added the help wanted Extra attention is needed label Apr 28, 2023
@hamersaw hamersaw mentioned this issue Aug 15, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamersaw hamersaw

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
3 participants
@eapolinario @mucahitkantepe @hamersaw