Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override container image by using with_overrides #3722

Closed
2 tasks done
jimxliu opened this issue May 24, 2023 · 1 comment
Closed
2 tasks done

Override container image by using with_overrides #3722

jimxliu opened this issue May 24, 2023 · 1 comment
Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers

Comments

@jimxliu
Copy link

jimxliu commented May 24, 2023

Motivation: Why do you think this is important?

The @task wrapped function inside the container image might not be aware of the container image fqn, since the image was not created when the task was being packaged into an image layer. So having the parent task in a separate container that knows child container image fqn, override the fqn of the child container image seems the way to go.

Goal: What should the final outcome look like, ideally?

Parent task can override child task container image at runtime using with_overrides(container_image='...').

Describe alternatives you've considered

Not sure if there is a workaround.

Propose: Link/Inline OR Additional context

Pull request: flyteorg/flytekit#1652

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@jimxliu jimxliu added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels May 24, 2023
@welcome
Copy link

welcome bot commented May 24, 2023

Thank you for opening your first issue here! 🛠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

No branches or pull requests

2 participants