-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Housekeeping] Remove storage as a task resource option #3955
Comments
hello @katrogan |
@samhita-alla, can you please assign this issue to me |
Please go ahead and create a PR, @Kota-Karthik, @Vishalk91-4. We will prioritize PRs based on a first-come, first-serve approach. |
Hi, @Kota-Karthik |
@dado5688 are you still up to work on this? |
@davidmirror-ops |
@katrogan, could you elaborate on what needs to be done please? |
Describe the issue
We only respect ephemeral storage request and actually delete the storage request from the generated pod spec: https://github.com/flyteorg/flyteplugins/blob/df62599965f04cd9b0ccfece5a00513ead7fed5d/go/tasks/pluginmachinery/flytek8s/container_helper.go#L162
If the resource is unused we shouldn't allow it to be set since this is a confusing user experience
What if we do not do this?
Confusing DevX with unrespected task resource specification.
Related component(s)
flyteidl, flytekit, flyteplugins
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: