Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Remove storage as a task resource option #3955

Closed
2 tasks done
katrogan opened this issue Aug 14, 2023 · 7 comments · Fixed by #4658 or flyteorg/flytekit#2078
Closed
2 tasks done

[Housekeeping] Remove storage as a task resource option #3955

katrogan opened this issue Aug 14, 2023 · 7 comments · Fixed by #4658 or flyteorg/flytekit#2078
Assignees
Labels
good first issue Good for newcomers housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@katrogan
Copy link
Contributor

Describe the issue

We only respect ephemeral storage request and actually delete the storage request from the generated pod spec: https://github.com/flyteorg/flyteplugins/blob/df62599965f04cd9b0ccfece5a00513ead7fed5d/go/tasks/pluginmachinery/flytek8s/container_helper.go#L162

If the resource is unused we shouldn't allow it to be set since this is a confusing user experience

What if we do not do this?

Confusing DevX with unrespected task resource specification.

Related component(s)

flyteidl, flytekit, flyteplugins

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@katrogan katrogan added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Aug 14, 2023
@eapolinario eapolinario added the good first issue Good for newcomers label Aug 22, 2023
@Kota-Karthik
Copy link

hello @katrogan
I am interested in doing this issue
So kindly assign me this
Thank You : )

@Vishalk91-4
Copy link

@samhita-alla, can you please assign this issue to me

@samhita-alla
Copy link
Contributor

Please go ahead and create a PR, @Kota-Karthik, @Vishalk91-4. We will prioritize PRs based on a first-come, first-serve approach.

@dado5688
Copy link

Hi, @Kota-Karthik
May I ask if you are still work on this issue?

@davidmirror-ops
Copy link
Contributor

@dado5688 are you still up to work on this?

@dado5688
Copy link

dado5688 commented Oct 23, 2023

@davidmirror-ops
sure!
I'd like to know what I need to do is to remove all the usage about Resource Storage
or to add an warn to tell that Resource Storage is not support anymore when user trying to configure the Resource Storage?

@samhita-alla
Copy link
Contributor

@katrogan, could you elaborate on what needs to be done please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
8 participants