Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] AWS Batch Job’s cpu/mem not following Resources in the task decorator #4003

Closed
2 tasks done
jw0515 opened this issue Sep 1, 2023 · 2 comments
Closed
2 tasks done
Assignees
Labels
bug Something isn't working stale

Comments

@jw0515
Copy link
Contributor

jw0515 commented Sep 1, 2023

Describe the bug

After bumping flyte from v1.5.0 to v1.6.0 (also the same for v1.9.0, but 1.6.0 is the starting point that having this issue) I found that the task resource config doesn’t propagate to AWS Batch Job’s resource config, I define CPU and memory like this:

@task(requests=Resources(mem="16Gi", cpu="8"), task_config=AWSBatchConfig(platformCapabilities="EC2"))

But in AWS batch it’s always the default value that I defined in the helm chart:

  task_resource_defaults:
    task_resources:
      defaults:
        cpu: 1000m
        memory: 1000Mi
        storage: 1000Mi
      limits:
        cpu: 256
        memory: 512Gi
        storage: 512Gi

Expected behavior

AWS batch job using the resources I defined in the task decorator.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@jw0515 jw0515 added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Sep 1, 2023
@jw0515 jw0515 changed the title [BUG] [BUG] AWS Batch Job’s cpu/mem not following Resources in the task decorator Sep 1, 2023
@wild-endeavor wild-endeavor self-assigned this Sep 1, 2023
@wild-endeavor
Copy link
Contributor

There's suspicion this was caused by flyteorg/flytepropeller#544 @hamersaw will be following up.

@wild-endeavor wild-endeavor removed the untriaged This issues has not yet been looked at by the Maintainers label Sep 1, 2023
Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

3 participants