Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] provide clarification in the docs regarding interruptible behavior when using map tasks #4462

Closed
2 tasks done
Tracked by #5783
samhita-alla opened this issue Nov 20, 2023 · 4 comments · Fixed by #5845
Closed
2 tasks done
Tracked by #5783

[Docs] provide clarification in the docs regarding interruptible behavior when using map tasks #4462

samhita-alla opened this issue Nov 20, 2023 · 4 comments · Fixed by #5845
Assignees
@RaghavMangla
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest pri3

Comments

@samhita-alla
Copy link
Contributor

Description

TL;DR: interruptible should work the same with maptasks as with regular python tasks — the retries field in the task annotation shouldn't be necessary.

slack thread: https://discuss.flyte.org/t/13886407/hey-i-m-seeing-some-differences-in-how-spot-revocation-preem#f766657c-66b4-4e85-9d8c-bef4db83f3f6

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@samhita-alla samhita-alla added documentation Improvements or additions to documentation pri3 labels Nov 20, 2023
@davidmirror-ops davidmirror-ops mentioned this issue Sep 28, 2024
Closed
56 tasks
@RaghavMangla
Copy link
Contributor

Hi, I would like to work on this

@RaghavMangla RaghavMangla mentioned this issue Oct 14, 2024
Merged
3 tasks
@RaghavMangla
Copy link
Contributor

Hi! @samhita-alla @davidmirror-ops, my PR: #5845
lmk if any changes are required

@RaghavMangla
Copy link
Contributor

Hi! If everything looks fine, I think we can close this issue

@RaghavMangla
Copy link
Contributor

Hi, @samhita-alla @davidmirror-ops, my PR: #5845, can u pls provide a review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaghavMangla RaghavMangla

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest pri3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify behavior of interruptible map tasks RaghavMangla/flyte
3 participants
@samhita-alla @davidmirror-ops @RaghavMangla