Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Too many map executions shown in Flyte console #4531

Closed
2 tasks done
fg91 opened this issue Dec 5, 2023 · 4 comments
Closed
2 tasks done

[BUG] Too many map executions shown in Flyte console #4531

fg91 opened this issue Dec 5, 2023 · 4 comments
Labels
backlogged For internal use. Reserved for contributor team workflow. bug Something isn't working ui Admin console user interface

Comments

@fg91
Copy link
Member

fg91 commented Dec 5, 2023

Describe the bug

If one creates a map task over e.g. 5 inputs and on the platform side configures e.g. 2 log links for map tasks, FlyteConsole shows 10 map executions instead of 5.

Expected behavior

The number of executions shown in FlyteConsole should be equal to the number of pods.

Additional context to reproduce

Example from the docs:

import functools
from flytekit import map_task, task, workflow


@task
def multi_input_task(quantity: int, price: float, shipping: float) -> float:
    return quantity * price * shipping


@workflow
def multiple_workflow(list_q: list[int] = [1, 2, 3, 4, 5], p: float = 6.0, s: float = 7.0) -> list[float]:
    partial_task = functools.partial(multi_input_task, price=p, shipping=s)
    return map_task(partial_task)(quantity=list_q)

Screenshots

For two log links configured, FlyteConsole shows 10 executions instead of 5:

image

If we configure a third log link, the number of shown executions is 15.

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@fg91 fg91 added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Dec 5, 2023
Copy link

dosubot bot commented Dec 5, 2023

🤖

Hello @fg91,

I'm Dosu, a bot here to assist you with bugs, answer your questions, and guide you on your journey to becoming a contributor. While we wait for a human maintainer, I'm here to help you out! It's nice to meet you and I look forward to helping you with your issue.

Thank you for reporting this issue. It seems similar to a previously resolved issue: [BUG] Mapped tasks with more than on log links do not render correctly. The solution to that issue was implemented in these pull requests: PR 725 and PR 727. However, I couldn't find the exact changes made in these pull requests within the repository.

Regarding the function of log links in FlyteConsole, they provide direct access to the logs of the tasks executed as part of the workflows. In the context of map tasks, each task execution in the map task will have its own set of logs. The log links in the FlyteConsole will direct you to the logs of each individual task execution. This behavior might depend on the specific configuration of your Flyte deployment and the plugins you are using. You can find more details in the task_logs.yaml file.

Given the information available, it's difficult to provide a definitive solution to your issue. Could you please provide more details about your Flyte deployment and configuration, especially the plugins you are using? This will help in understanding the issue better and finding a suitable solution.

Sources


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@eapolinario
Copy link
Contributor

@fg91 , do you also see the same with array node map tasks?

@eapolinario eapolinario added ui Admin console user interface backlogged For internal use. Reserved for contributor team workflow. and removed untriaged This issues has not yet been looked at by the Maintainers labels Dec 7, 2023
@fg91
Copy link
Member Author

fg91 commented Feb 8, 2024

@fg91 , do you also see the same with array node map tasks?

Yes, we do 👍

@fg91
Copy link
Member Author

fg91 commented Jun 16, 2024

The Flyteconsole/UI revamp released with 1.12 appears to have fixed this.

@fg91 fg91 closed this as completed Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlogged For internal use. Reserved for contributor team workflow. bug Something isn't working ui Admin console user interface
Projects
None yet
Development

No branches or pull requests

2 participants