[BUG] flytekit uses fork when requesting remote OAuth credentials, which is not supported on Windows

[ai-rnatour]

Describe the bug

When requesting remote OAuth credentials via a user's default browser, flytekit is hardcoded to use fork to launch a background process that listens for the credential callback. Windows does not support fork, so users receive an error.

Code link

Expected behavior

flytekit should use the spawn method or, better yet, the OS default to launch this background service.

Python docs

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

• Yes

Have you read the Code of Conduct?

• Yes

[welcome]

Thank you for opening your first issue here! 🛠

[dosubot]

It's great that you've identified this issue and provided a potential solution using the spawn method. Your contribution to addressing this compatibility issue for Windows users would be highly valuable. I encourage you to go ahead and create a pull request with your proposed fix. Thank you for your willingness to contribute to the project!

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

[ai-rnatour]

I found a quick and dirty workaround by monkeypatching in a custom class to use meanwhile:

class MyAuthorizationClient(AuthorizationClient):
    def get_creds_from_remote(self) -> Credentials:
        q: Queue[Credentials] = Queue()
        server = self._create_callback_server()
        try:
            with ThreadPoolExecutor(max_workers=1) as executor:
                executor.submit(server.handle_request, q)  # no need to wait, we will receive the auth code on the queue
                self._request_authorization_code()
                auth_code = q.get()
                return self._request_access_token(auth_code)
        finally:
            server.server_close()

# monkeypatch in MyAuthorizationClient in module using flytekit
flytekit.clients.auth.authenticator.AuthorizationClient = MyAuthorizationClient

Seems to work so far but I don't expect this to be a very robust solution.