Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Explore reenabling protoc-gen-validate #5101

Open
2 tasks done
katrogan opened this issue Mar 25, 2024 · 1 comment
Open
2 tasks done

[Housekeeping] Explore reenabling protoc-gen-validate #5101

katrogan opened this issue Mar 25, 2024 · 1 comment
Labels
backlogged For internal use. Reserved for contributor team workflow. housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@katrogan
Copy link
Contributor

Describe the issue

#4643 removed this, but flyteadmin validation code checks a ton of request fields for whether they're empty https://github.com/search?q=repo%3Aflyteorg%2Fflyte%20ValidateEmptyStringField&type=code

this manual code (and other checks) could be moved to the pb layer and invoked as middleware to automate these checks

What if we do not do this?

more hand-curated code, easy to miss adding for new apis

Related component(s)

flyteidl, flyteadmin

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@katrogan katrogan added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Mar 25, 2024
@katrogan
Copy link
Contributor Author

cc @eapolinario

@eapolinario eapolinario added the backlogged For internal use. Reserved for contributor team workflow. label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlogged For internal use. Reserved for contributor team workflow. housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Development

No branches or pull requests

2 participants