Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] with_overrides unsets timeout if not specified #6153

Open
2 tasks done
pvditt opened this issue Jan 9, 2025 · 0 comments
Open
2 tasks done

[BUG] with_overrides unsets timeout if not specified #6153

pvditt opened this issue Jan 9, 2025 · 0 comments
Assignees
Labels
bug Something isn't working flytekit FlyteKit Python related issue

Comments

@pvditt
Copy link
Contributor

pvditt commented Jan 9, 2025

Describe the bug

with_overrides will unset a timeout if timeout is not specified in the with_overrides call.

https://github.com/flyteorg/flytekit/blob/4e93e36843b8f13f06eb088e1a46232ad1fb225d/flytekit/core/node.py#L178

Expected behavior

with_overrides should only override specified params

Additional context to reproduce

@task(
    cache=True,
    cache_version="v1.0",
    timeout=timedelta(seconds=20),
)
def basic_cache(num: str) -> str:
    return f"Hi: {num[0]} ugh-1"


@workflow()
def task_metadata_wf() -> str:
    return basic_cache(num="1").with_overrides(cache_version="v1.1")

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@pvditt pvditt added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Jan 9, 2025
@pvditt pvditt self-assigned this Jan 9, 2025
@pvditt pvditt changed the title [BUG] with_overrides unsets timeout is not specified [BUG] with_overrides unsets timeout if not specified Jan 9, 2025
@eapolinario eapolinario added flytekit FlyteKit Python related issue and removed untriaged This issues has not yet been looked at by the Maintainers labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue
Projects
Status: Backlog
Development

No branches or pull requests

2 participants