From 72f2adcd734ee1e8a6954e6849064cccf6f7787d Mon Sep 17 00:00:00 2001 From: Eduardo Apolinario Date: Thu, 8 Aug 2024 17:08:22 -0400 Subject: [PATCH 1/2] Fetch all tags in flyteidl-release.yml Signed-off-by: Eduardo Apolinario --- .github/workflows/flyteidl-release.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/flyteidl-release.yml b/.github/workflows/flyteidl-release.yml index 2b19f7942d..8fbdbbe295 100644 --- a/.github/workflows/flyteidl-release.yml +++ b/.github/workflows/flyteidl-release.yml @@ -34,6 +34,8 @@ jobs: working-directory: flyteidl steps: - uses: actions/checkout@v4 + with: + fetch-depth: '0' - name: Set up Python uses: actions/setup-python@v1 with: @@ -65,7 +67,7 @@ jobs: - name: Set version in npm package run: | # from refs/tags/v1.2.3 get 1.2.3 - VERSION=$(echo $GITHUB_REF | sed 's#.*/v##') + VERSION=$(echo ${{ inputs.version }} | sed 's#.*/v##') VERSION=$VERSION make update_npmversion shell: bash - run: | From 6a3f0c607c5dbffeb0ee5a109c01277d1f0694f5 Mon Sep 17 00:00:00 2001 From: Eduardo Apolinario Date: Thu, 8 Aug 2024 17:09:46 -0400 Subject: [PATCH 2/2] Fix sed expression for npm job Signed-off-by: Eduardo Apolinario --- .github/workflows/flyteidl-release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/flyteidl-release.yml b/.github/workflows/flyteidl-release.yml index 8fbdbbe295..c895beba4b 100644 --- a/.github/workflows/flyteidl-release.yml +++ b/.github/workflows/flyteidl-release.yml @@ -66,8 +66,8 @@ jobs: registry-url: "https://registry.npmjs.org" - name: Set version in npm package run: | - # from refs/tags/v1.2.3 get 1.2.3 - VERSION=$(echo ${{ inputs.version }} | sed 's#.*/v##') + # v1.2.3 get 1.2.3 + VERSION=$(echo ${{ inputs.version }} | sed 's#.*v##') VERSION=$VERSION make update_npmversion shell: bash - run: |