From 06740017f0cf8bc7628a115978ab3bf6512b39b1 Mon Sep 17 00:00:00 2001 From: Haytham Abuelfutuh Date: Mon, 1 Mar 2021 13:18:38 -0800 Subject: [PATCH] lint --- .golangci.yml | 5 +++++ pkg/config/third_party_config.go | 4 ++-- pkg/manager/impl/execution_manager.go | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 3df02b549..ec9fb06dd 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -25,3 +25,8 @@ linters: - unparam - unused - varcheck + +issues: + exclude: + # staticcheck + - "SA1019: request.GetSpec().GetInputs is deprecated: Do not use." \ No newline at end of file diff --git a/pkg/config/third_party_config.go b/pkg/config/third_party_config.go index 2e4c5ad77..785c6e445 100644 --- a/pkg/config/third_party_config.go +++ b/pkg/config/third_party_config.go @@ -7,6 +7,6 @@ type ThirdPartyConfigOptions struct { } type FlyteClientConfig struct { - ClientID string `json:"clientId" pflag:",public identifier for the app which handles authorization for a Flyte deployment"` - RedirectURI string `json:"redirectUri" pflag:",This is the callback uri registered with the app which handles authorization for a Flyte deployment"` + ClientID string `json:"clientId" pflag:",public identifier for the app which handles authorization for a Flyte deployment"` + RedirectURI string `json:"redirectUri" pflag:",This is the callback uri registered with the app which handles authorization for a Flyte deployment"` } diff --git a/pkg/manager/impl/execution_manager.go b/pkg/manager/impl/execution_manager.go index 1453fb88c..283dba6c2 100644 --- a/pkg/manager/impl/execution_manager.go +++ b/pkg/manager/impl/execution_manager.go @@ -735,6 +735,7 @@ func (m *ExecutionManager) CreateExecution( *admin.ExecutionCreateResponse, error) { // Prior to flyteidl v0.15.0, Inputs was held in ExecutionSpec. Ensure older clients continue to work. if request.Inputs == nil || len(request.Inputs.Literals) == 0 { + //lint:ignore SA1019 request.Inputs = request.GetSpec().GetInputs() } var executionModel *models.Execution