From 115f1fe97eb4aee09039066602067a608e6cb085 Mon Sep 17 00:00:00 2001
From: Eugene Jahn <eugenejahnjahn@gmail.com>
Date: Thu, 19 May 2022 02:10:37 -0700
Subject: [PATCH] feat: task rerurn done

Signed-off-by: Eugene Jahn <eugenejahnjahn@gmail.com>
---
 .../NodeExecutionDetailsPanelContent.tsx                 | 3 ++-
 .../components/Launch/LaunchForm/LaunchFormDialog.tsx    | 9 ++++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/packages/zapp/console/src/components/Executions/ExecutionDetails/NodeExecutionDetailsPanelContent.tsx b/packages/zapp/console/src/components/Executions/ExecutionDetails/NodeExecutionDetailsPanelContent.tsx
index ec8ee7573..b1643c22b 100644
--- a/packages/zapp/console/src/components/Executions/ExecutionDetails/NodeExecutionDetailsPanelContent.tsx
+++ b/packages/zapp/console/src/components/Executions/ExecutionDetails/NodeExecutionDetailsPanelContent.tsx
@@ -1,6 +1,6 @@
 import * as React from 'react';
 import { useEffect, useMemo, useRef, useState } from 'react';
-import { IconButton, Typography, Tab, Tabs, Button } from '@material-ui/core';
+import { IconButton, Typography, Tab, Tabs } from '@material-ui/core';
 import { makeStyles, Theme } from '@material-ui/core/styles';
 import Close from '@material-ui/icons/Close';
 import ArrowBackIos from '@material-ui/icons/ArrowBackIos';
@@ -240,6 +240,7 @@ export const NodeExecutionDetailsPanelContent: React.FC<NodeExecutionDetailsProp
   const styles = useStyles();
   const queryClient = useQueryClient();
   const detailsContext = useNodeExecutionContext();
+
   const [isReasonsVisible, setReasonsVisible] = useState<boolean>(false);
   const [dag, setDag] = useState<any>(null);
   const [details, setDetails] = useState<NodeExecutionDetails | undefined>();
diff --git a/packages/zapp/console/src/components/Launch/LaunchForm/LaunchFormDialog.tsx b/packages/zapp/console/src/components/Launch/LaunchForm/LaunchFormDialog.tsx
index 2b22e00bb..cbcb1b7df 100644
--- a/packages/zapp/console/src/components/Launch/LaunchForm/LaunchFormDialog.tsx
+++ b/packages/zapp/console/src/components/Launch/LaunchForm/LaunchFormDialog.tsx
@@ -19,15 +19,18 @@ export const LaunchFormDialog: React.FC<{
 }> = ({ className, id, showLaunchForm, setShowLaunchForm }) => {
   const onCancelLaunch = () => setShowLaunchForm(false);
 
+  // prevent child onclick event in the dialog triggers parent onclick event
+  const dialogOnClick = (e: React.MouseEvent<HTMLElement>) => {
+    e.stopPropagation();
+  };
+
   return (
     <Dialog
       scroll="paper"
       maxWidth="sm"
       fullWidth={true}
       open={showLaunchForm}
-      onClick={(e) => {
-        e.stopPropagation();
-      }}
+      onClick={dialogOnClick}
     >
       <LaunchForm onClose={onCancelLaunch} {...getLaunchProps(id)} />
     </Dialog>