From e5f9a8b00ac54cf370f0ccb07d6a8677066d33e0 Mon Sep 17 00:00:00 2001 From: Jason Porter <84735036+jsonporter@users.noreply.github.com> Date: Fri, 3 Mar 2023 17:15:59 -0800 Subject: [PATCH] fix: upgrading node version to 18 (#703) Upgrading node version to 18 Signed-off-by: Jason Porter --- .github/workflows/checks.yml | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index 8c84b322e..d1973a60d 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -31,7 +31,7 @@ jobs: fetch-depth: 0 - uses: actions/setup-node@v2 with: - node-version: 16 + node-version: 18 - uses: bahmutov/npm-install@v1 - name: Run tests and generate coverage run: make test_unit_codecov @@ -46,7 +46,7 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-node@v2 with: - node-version: 16 + node-version: 18 - uses: bahmutov/npm-install@v1 - name: Run linter run: make lint @@ -66,7 +66,13 @@ jobs: release: name: Generate Release if: ${{ (github.event_name != 'pull_request') && (needs.extract_branch.outputs.branch == 'master') }} - needs: [unit_tests_with_coverage, lint_project, build_docker_image, extract_branch] + needs: + [ + unit_tests_with_coverage, + lint_project, + build_docker_image, + extract_branch, + ] runs-on: ubuntu-latest steps: - name: Checkout @@ -74,7 +80,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v1 with: - node-version: 16 + node-version: 18 - name: Install dependencies run: yarn install --frozen-lockfile - name: Release @@ -113,7 +119,7 @@ jobs: push_docker_image: name: Build & Push FlyteConsole Image if: ${{ needs.check_for_tag.outputs.currentTag != '' }} - needs: [ check_for_tag ] + needs: [check_for_tag] uses: flyteorg/flytetools/.github/workflows/publish.yml@master with: before-build: |