Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge devmain into master #632

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Conversation

olga-union
Copy link
Contributor

@olga-union olga-union commented Nov 2, 2022

Signed-off-by: Olga Nad [email protected]

TL;DR

Merging in UI feature work around gate nodes, plus completed refactor of the execution page.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

1. Gate Nodes:

  • Implemented launch form for gate nodes, which allows to resume workflow.
  • Updated views of the Nodes and Graph tabs and Node Details slide-out right sidebar to distinguish gate nodes from the others.
    Gate nodes can be in Paused state, and when they are, in the Nodes list the Resume button was added to launch the form. In the Graph tab paused nodes will also render the same button within the node item, and in the bottom left corner a Paused tasks button will appear similar to the Legend button, containing the list of all paused nodes in the workflow, with the ability to quickly launch the resume form from the list by clicking on the Resume button for the selected item. Details slide-out tab is also improved to include Resume button in the header section.

2. Execution Page Refactor:
Completed data standardization between all 3 tab views on the page - data is being loaded and transformed on the page level, and then each tab consumes everything it needs to fulfill its render purpose:

  • This helped us synchronize node lists, names and other display data for an uniform experience across tabs, preserve the Details slide-out of the selected node, when switching between tabs, and significantly minimized the potential for experiencing bugs that are only present in one tab.
  • The key improvement of the refactor is the minimization of network calls, since every data piece needed to display tabs is being pre-loaded, switching between them doesn't incur additional or repeated requests, hence jumping between tabs only lags by the time needed to render each component. The only downside of this approach is the initial loading period for bigger workflows.

Tracking Issue

NA

Follow-up issue

NA

@olga-union olga-union changed the title fix: merge devmain into master feat: merge devmain into master Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #632 (d4dad9d) into master (b06cc84) will decrease coverage by 0.85%.
The diff coverage is 77.32%.

@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
- Coverage   69.08%   68.22%   -0.86%     
==========================================
  Files         440      448       +8     
  Lines       10434    10670     +236     
  Branches     1789     1838      +49     
==========================================
+ Hits         7208     7280      +72     
- Misses       3226     3390     +164     
Impacted Files Coverage Δ
...components/Executions/ExecutionDetails/strings.tsx 100.00% <ø> (ø)
...sole/src/components/Executions/Tables/constants.ts 100.00% <ø> (ø)
...console/src/components/Executions/Tables/styles.ts 100.00% <ø> (ø)
.../components/Executions/TaskExecutionsList/utils.ts 98.18% <ø> (+4.15%) ⬆️
...app/console/src/components/Executions/constants.ts 100.00% <ø> (ø)
...ider/NodeExecutionDetails/createExecutionArray.tsx 62.74% <0.00%> (-8.37%) ⬇️
.../zapp/console/src/components/Executions/strings.ts 100.00% <ø> (ø)
...console/src/components/Launch/LaunchForm/styles.ts 100.00% <ø> (ø)
.../console/src/components/Launch/LaunchForm/types.ts 100.00% <ø> (ø)
...ages/zapp/console/src/components/common/strings.ts 100.00% <ø> (ø)
... and 111 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Olga Nad <[email protected]>
@olga-union olga-union requested review from a team, ursucarina, eugenejahn and jsonporter and removed request for a team November 2, 2022 18:55
@jsonporter jsonporter merged commit ab19c54 into master Nov 2, 2022
@jsonporter jsonporter deleted the olga-union/merge-devmain branch November 2, 2022 22:57
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants