Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: launch form fixes #785

Merged
merged 19 commits into from
Jul 14, 2023
Merged

fix: launch form fixes #785

merged 19 commits into from
Jul 14, 2023

Conversation

ursucarina
Copy link
Contributor

@ursucarina ursucarina commented Jun 29, 2023

TL;DR

Fixes launch form scenarios

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Launch form fixes:

  • List of optionals
  • error bubbling and form validation
  • deeply nested collections
  • ui updates (borders around nested inputs, error messaging)

Test on:

  • console/projects/flytesnacks/domains/development/workflows/sadtalker.workflows.src.test_audio2coeff.audio_to_coeff_wf?duration=all
  • console/projects/flytesnacks/domains/development/workflows/exhaustive.complete?duration=all
  • List of optionals: /console/projects/flytesnacks/domains/development/workflows/test-sandbox.workflows.example.wf?duration=all

Tracking Issue

fixes flyteorg/flyte#3785

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Carina Ursu <[email protected]>
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #785 (57bcf26) into master (f6d5fb9) will decrease coverage by 0.36%.
The diff coverage is 51.46%.

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
- Coverage   67.55%   67.19%   -0.36%     
==========================================
  Files         492      499       +7     
  Lines       12045    12207     +162     
  Branches     2238     2242       +4     
==========================================
+ Hits         8137     8203      +66     
- Misses       3908     4004      +96     
Impacted Files Coverage Δ
...sole/src/components/Launch/LaunchForm/getInputs.ts 80.76% <ø> (ø)
...nsole/src/components/Launch/LaunchForm/handlers.ts 85.71% <ø> (ø)
...mponents/Launch/LaunchForm/inputHelpers/boolean.ts 92.30% <0.00%> (-7.70%) ⬇️
...ponents/Launch/LaunchForm/inputHelpers/datetime.ts 90.47% <0.00%> (-9.53%) ⬇️
...ponents/Launch/LaunchForm/inputHelpers/duration.ts 88.23% <0.00%> (-11.77%) ⬇️
...components/Launch/LaunchForm/inputHelpers/float.ts 89.47% <0.00%> (-10.53%) ⬇️
...mponents/Launch/LaunchForm/inputHelpers/integer.ts 91.30% <0.00%> (-8.70%) ⬇️
.../components/Launch/LaunchForm/inputHelpers/none.ts 50.00% <0.00%> (-33.34%) ⬇️
...omponents/Launch/LaunchForm/inputHelpers/schema.ts 85.71% <0.00%> (-14.29%) ⬇️
...ch/LaunchForm/inputHelpers/test/structTestCases.ts 100.00% <ø> (ø)
... and 37 more

... and 1 file with indirect coverage changes

Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
@ursucarina ursucarina requested review from a team, jsonporter, 4nalog and james-union and removed request for a team July 10, 2023 14:37
@ursucarina ursucarina merged commit 1da4d7a into master Jul 14, 2023
@ursucarina ursucarina deleted the carina/launchform branch July 14, 2023 20:44
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.8.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot kickoff executions for workflows containing parameter of type List[Optional[X]]
3 participants