Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Set scheduler restart policy to Always #367

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

bstadlbauer
Copy link
Member

TL;DR

In dask/dask-kubernetes#711 dask-kubernetes switched to deploying the scheduler pod through a Deployment instead of a simple PodSpec. Within a Deployment, only RestartPolicy: Always is allowed and will lead to

spec.template.spec.restartPolicy: Unsupported value: "Never": supported values: Always

otherwise.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Signed-off-by: Bernhard Stadlbauer <[email protected]>
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #367 (616e37f) into master (df62599) will increase coverage by 1.30%.
The diff coverage is 100.00%.

❗ Current head 616e37f differs from pull request most recent head 2b0b21c. Consider uploading reports for the commit 2b0b21c to get more accurate results

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
+ Coverage   62.90%   64.21%   +1.30%     
==========================================
  Files         153      153              
  Lines       12893    10442    -2451     
==========================================
- Hits         8110     6705    -1405     
+ Misses       4170     3124    -1046     
  Partials      613      613              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/plugins/k8s/dask/dask.go 85.95% <100.00%> (+3.07%) ⬆️

... and 133 files with indirect coverage changes

@hamersaw hamersaw merged commit f7b37aa into flyteorg:master Jun 29, 2023
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Signed-off-by: Bernhard Stadlbauer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants