Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: Use native .findIndex() as IE is not supported by MS #1305

Closed
tomasvn opened this issue Nov 14, 2024 · 2 comments · Fixed by #1307
Closed

[Feat]: Use native .findIndex() as IE is not supported by MS #1305

tomasvn opened this issue Nov 14, 2024 · 2 comments · Fixed by #1307

Comments

@tomasvn
Copy link
Contributor

tomasvn commented Nov 14, 2024

focus-trap/index.js

Line 72 in e125da3

const findIndex = function (arr, fn) {

@stefcameron
Copy link
Member

Thanks for pointing out that old code. Yes, we could definitely drop that polyfill in favor of the native API now.

@tomasvn tomasvn mentioned this issue Nov 16, 2024
Merged
3 tasks
@stefcameron
Copy link
Member

Fixed with #1306

@github-actions github-actions bot mentioned this issue Nov 16, 2024
Merged
This was referenced Nov 16, 2024
Closed
Merged
Open
Open
Merged
Open
Open
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 29, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version Packages focus-trap/focus-trap
2 participants
@stefcameron @tomasvn