Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show order [management]: Adapt column headings? + append supplier order unit for all articles? #1096

Open
twothreenine opened this issue Apr 18, 2024 · 2 comments · May be fixed by #1073
Open
Assignees

Comments

@twothreenine
Copy link
Contributor

twothreenine commented Apr 18, 2024

Column headings:
"Members" is confusing and was never translated. I suggest changing it to "Total order", or whatever term we agree on in #1097.
Same for "Full units" -> "Order result"?

Then for some articles, the supplier order unit isn't shown in the far right column:

  • In case of beer, you wouldn't know if it refers to 20.0 l or 20.0 x Bottle (0.5 l).
  • In case of potatoes, we need it since it differs from the group order unit.
  • For carrots & oyster mushrooms (supplier order unit == group order unit) we don't really need it, I'm unsure if it should be appended for the sake of completeness or omitted to underline it's the same as the group order unit.

grafik

This also applies to the receive menu:
grafik

@twothreenine twothreenine self-assigned this Apr 27, 2024
@twothreenine
Copy link
Contributor Author

I thought about the terminology in the column headings across various views, also in regards to upstream/#1016.
My key thoughts:

  • there should be a consistent terminology in the frontend
  • some headings should depend on the order's state

Here are my notes, which go beyond this issue and also beyond the aim of this fork:
Hackathon received etc columns.xlsx

@lentschi lentschi assigned lentschi and unassigned twothreenine Jun 22, 2024
lentschi referenced this issue in foodcoops/foodsoft_hackathon Jun 22, 2024
lentschi referenced this issue in foodcoops/foodsoft_hackathon Jun 22, 2024
@lentschi
Copy link
Contributor

The issue with the missing units is fixed by foodcoops/foodsoft_hackathon@b38dfb0, the issue with the column renaming/ordering remains, but is not directly related to the fork, so I'll move it to the post-merge milestone.

lentschi referenced this issue in foodcoops/foodsoft_hackathon Jul 26, 2024
lentschi referenced this issue in foodcoops/foodsoft_hackathon Oct 11, 2024
@lentschi lentschi transferred this issue from foodcoops/foodsoft_hackathon Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants