Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic changes for delete confirmation message #619

Closed
tanmayrauth opened this issue Jan 5, 2020 · 1 comment
Closed

Semantic changes for delete confirmation message #619

tanmayrauth opened this issue Jan 5, 2020 · 1 comment

Comments

@tanmayrauth
Copy link
Contributor

Describe the feature you'd like
Delete message for Badge and clipart are:

  • Delete badge successfully and Delete clipart successfully.

Which is semantically not correct. It should be:

  • Badge deleted successfully and Clipart deleted successfully.

For saving the clipart the message is correct: Clipart saved successfully.

So doing the changes for delete msg on similar lines.

Would you like to work on the issue?
Yes

@tanmayrauth
Copy link
Contributor Author

This is merged now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant