Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pantheon.yml update fails sometimes #42

Open
generalredneck opened this issue Nov 6, 2023 · 0 comments
Open

Pantheon.yml update fails sometimes #42

generalredneck opened this issue Nov 6, 2023 · 0 comments

Comments

@generalredneck
Copy link
Collaborator

Uri Frazier
6 days ago
Has anyone run into this error in CircleCi while updating pantheon.yml so that the site uses Solr8?
'8# Workaround change to pantheon.yml to force envrionment update' is not one of [3, 8]
(Reference: https://docs.pantheon.io/pantheon-yml)
3 files

image
image

Dave Hansen-Lange
6 days ago
I might’ve heard something where there’s a trick to get Circle-managed multidevs to recognize changes to pantheon.yml.
@genred
Would know.

Allan Chappell
6 days ago
yeah... if you are using Project CI... it's built in

Uri Frazier
6 days ago
It worked to get PHP updated (php_version), but it's not liking this search change. (edited)

Allan Chappell
6 days ago
this is the part:
https://github.com/fourkitchens/pots/blob/main/scripts/pantheon/deploy#L90-L93

deploy
if [[ ! -z "$PANTHEON_YML_DIFF" || ! -z "$PANTHEON_UPSTREAM_YML_DIFF" ]]; then
echo "# Workaround change to pantheon.yml to force envrionment update" >> pantheon.yml
terminus -n build:env:push "$TERMINUS_SITE.$TERMINUS_ENV" --message="Workaround change to pantheon.yml to force envrionment update"
fi
https://github.com/[fourkitchens/pots](https://github.com/fourkitchens/pots)|fourkitchens/potsfourkitchens/pots | Added by GitHub

Dave Hansen-Lange
6 days ago
@genred
See the screenshot. That part seems to be erroring out.

Allan Chappell
6 days ago
yeah I see that

Allan Chappell
6 days ago
ok so pantheon.yml doesn't end with an endline

Allan Chappell
6 days ago
all linux files should have an eol at the end of the file

Allan Chappell
6 days ago
that's best practice

Uri Frazier
6 days ago
Ahh - thanks!
@genred

  • I'll give that a try.

Allan Chappell
6 days ago
we can make an issue out of that (edited)

Allan Chappell
6 days ago
cause I could always add an EOL in there to make sure

Uri Frazier
6 days ago
That fixed the CircleCi error - thanks again!
@genred
&
@Dave
for flagging Allan.

@cbfannin cbfannin assigned cbfannin and unassigned cbfannin Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants