Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setTimeout(x) value doesn't work intermittently #45

Closed
srathor8x8 opened this issue Jun 12, 2024 · 8 comments
Closed

setTimeout(x) value doesn't work intermittently #45

srathor8x8 opened this issue Jun 12, 2024 · 8 comments
Assignees
Labels

Comments

@srathor8x8
Copy link

Hi - We are using this library to run some rsync operations and have used a output processing timeout to be 1800 secs(30 mins). Once in a while, it not working and the thread which runs the rsync process gets stuck at at wait() method here in monitor() (AbstractProcessOutput.java).

image This thread got stuck for several days and was recovered by manual intervention. We are using rsync version rsync4j-all:3.2.3-10.
@fracpete
Copy link
Owner

I've pushed out a new release of processoutput4j which you could try instead of the version that rsync4j uses:

    <dependency>
      <groupId>com.github.fracpete</groupId>
      <artifactId>processoutput4j</artifactId>
      <version>0.0.12</version>
    </dependency>

@fracpete fracpete self-assigned this Jun 12, 2024
@fracpete fracpete added the bug label Jun 12, 2024
@srathor8x8
Copy link
Author

Does it contain any such probable fixes?

@fracpete
Copy link
Owner

Yes, I made the release specifically for that purpose.

@srathor8x8
Copy link
Author

srathor8x8 commented Jun 13, 2024

Okay Thanks. So basically, if we are using rsync-3.3.0-0, internally it shall already be using 0.0.12 for processoutput4j, right?

@fracpete
Copy link
Owner

You can also use your current rsync4j version (there is no rsync4j release with processoutput4j 0.0.12 yet), simply upgrade the processoutput4j dependency.

@srathor8x8
Copy link
Author

Ok. Thanks. Few questions here:

  1. As we have the new rsync lib also available, what would be merit of using this version over 3.2.3-10.
  2. And if use it - are there any kind of regressions which are possible and we should possible test?
  3. Similarly for processoutpu4j new version, what kind of area we should focus more on testing considering this is a upgraded new release.

@fracpete
Copy link
Owner

  1. See the release notes of rsync4j and the release notes of rsync itself (Windows users only due to bundling of binaries, Linux/Mac check your underlying OS binary of rsync for version)
  2. See 1.
  3. processoutput4j - the only change was in regards to timeout handling, very minimal impact.

@fracpete
Copy link
Owner

due to no further feedback, assuming to be fixed (96e3db7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants