-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tasks creating filters both in legacy or new way #2172
Comments
Option 1 is obviously safer, but if we think that nobody ever used cc @jluethi |
Hmm, I think some type filters are used in tasks. For example here: We also document this feature here: https://fractal-analytics-platform.github.io/tasks_spec/#output-api Thus, I'd say we should use Option 1. And then update both the documentation as well as the known examples to move to the new, simpler system |
This one is only setting types, and not type filters. This one indeed forces us to use option 1 (ref fractal-analytics-platform/fractal-helper-tasks#19). |
This is made obsolete by #2188 |
Current server/task interface includes:
As of #2168, in principle this should become
but doing so would break the existing server/task interface.
We have two options:
Option 1 (backwards compatible)
We accept both the previous and upcoming task outputs, and convert them all to the upcoming version
Option 2 (breaking)
We simply fail for any task that sets
filters
, that is, we only support the upcoming version.The text was updated successfully, but these errors were encountered: