Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA: Employee can select the approval status while creating new expense claim #1866

Closed
1 task done
fadilsiddique opened this issue Jun 8, 2024 · 2 comments · Fixed by #1887
Closed
1 task done

PWA: Employee can select the approval status while creating new expense claim #1866

fadilsiddique opened this issue Jun 8, 2024 · 2 comments · Fixed by #1887
Labels
bug Something isn't working released

Comments

@fadilsiddique
Copy link

Information about bug

When creating a new expense claim, employee can able to select the approval status as approved or rejected.

WhatsApp Image 2024-06-08 at 4 28 42 PM

Module

HR

Version

ERPNext: v15.26.0 (version-15)

Frappe Framework: v15.29.0 (version-15)

Frappe HR: v15.21.2 (version-15)

Installation method

None

Relevant log output / Stack trace / Full Error Message.

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@fadilsiddique fadilsiddique added the bug Something isn't working label Jun 8, 2024
@fadilsiddique fadilsiddique changed the title Employee can select the approval status while creating new expense claim PWA: Employee can select the approval status while creating new expense claim Jun 8, 2024
@fadilsiddique
Copy link
Author

fix #1872

@ruchamahabal ruchamahabal mentioned this issue Jun 12, 2024
Merged
@mergify mergify bot mentioned this issue Jun 12, 2024
Merged
@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 15.22.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(PWA): make approval fields & buttons permission sensitive based on permlevel ruchamahabal/hrms
2 participants
@frappe-pr-bot @fadilsiddique