Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SQLite #11

Closed
bendavies opened this issue Jan 22, 2014 · 3 comments · Fixed by #12
Closed

Support SQLite #11

bendavies opened this issue Jan 22, 2014 · 3 comments · Fixed by #12
Assignees
@fre5h
Labels
improvement

Comments

@bendavies
Copy link
Contributor

Hi,

I know that SQLite doesn't natively support ENUM's, but can AbstractEnumType::getSqlDeclaration be made to support enums? Maybe just define the field as a string type.

This would be for functional testing purposes.

Thanks!
@bendavies
Copy link
Contributor Author

apparently this can be simulate in SQLite with the check constraint

position TEXT CHECK( position IN ('PG','SG','SF', 'PF', 'C') ) NOT NULL

Would you be interested in a PR for this?

@fre5h
Copy link
Owner

fre5h commented Jan 22, 2014

@bendavies You are welcome. Would be good to discuss this feature

@bendavies
Copy link
Contributor Author

@fre5h we'll i've got this working in my application.
I'll submit a PR

@bendavies bendavies mentioned this issue Jan 22, 2014
Merged
@fre5h fre5h closed this as completed in #12 Jan 27, 2014
@fre5h fre5h self-assigned this Aug 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fre5h fre5h

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support SQLite for functional testing purposes bendavies/DoctrineEnumBundle
2 participants
@bendavies @fre5h