Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HWP/HWPX files in Qubes OS #494

Open
deeplow opened this issue Aug 1, 2023 · 0 comments
Open

Add support for HWP/HWPX files in Qubes OS #494

deeplow opened this issue Aug 1, 2023 · 0 comments
Labels
Milestone

Comments

@deeplow
Copy link
Contributor

deeplow commented Aug 1, 2023

In #460 we added support for HWP/HWPX files in all platforms except Qubes. So we still need to ship the libreoffice extension in Qubes and dynamically install it in the disposable qube, when needed.

@deeplow deeplow added this to the 0.5.0 milestone Aug 1, 2023
@deeplow deeplow added the P:Qubes QubesOS integration label Aug 1, 2023
apyrgio added a commit that referenced this issue Aug 3, 2023
The HWP / HWPX conversion feature does not work on the following
platforms:

* MacOS with Apple Silicon CPU
* Native Qubes OS

For this reason, we need to:

1. Disable it on the GUI side, by not allowing the user to select these
   files.
2. Throw an error on the isolation provider side, in case the user
   directly attempts to convert the file (either through CLI or via
   "Open With").

Refs #494
Refs #498
apyrgio added a commit that referenced this issue Aug 3, 2023
The HWP / HWPX conversion feature does not work on the following
platforms:

* MacOS with Apple Silicon CPU
* Native Qubes OS

For this reason, we need to:

1. Disable it on the GUI side, by not allowing the user to select these
   files.
2. Throw an error on the isolation provider side, in case the user
   directly attempts to convert the file (either through CLI or via
   "Open With").

Refs #494
Refs #498
apyrgio added a commit that referenced this issue Aug 3, 2023
The HWP / HWPX conversion feature does not work on the following
platforms:

* MacOS with Apple Silicon CPU
* Native Qubes OS

For this reason, we need to:

1. Disable it on the GUI side, by not allowing the user to select these
   files.
2. Throw an error on the isolation provider side, in case the user
   directly attempts to convert the file (either through CLI or via
   "Open With").

Refs #494
Refs #498
apyrgio added a commit that referenced this issue Aug 3, 2023
The HWP / HWPX conversion feature does not work on the following
platforms:

* MacOS with Apple Silicon CPU
* Native Qubes OS

For this reason, we need to:

1. Disable it on the GUI side, by not allowing the user to select these
   files.
2. Throw an error on the isolation provider side, in case the user
   directly attempts to convert the file (either through CLI or via
   "Open With").

Refs #494
Refs #498
apyrgio added a commit that referenced this issue Aug 3, 2023
The HWP / HWPX conversion feature does not work on the following
platforms:

* MacOS with Apple Silicon CPU
* Native Qubes OS

For this reason, we need to:

1. Disable it on the GUI side, by not allowing the user to select these
   files.
2. Throw an error on the isolation provider side, in case the user
   directly attempts to convert the file (either through CLI or via
   "Open With").

Refs #494
Refs #498
apyrgio added a commit that referenced this issue Aug 3, 2023
The HWP / HWPX conversion feature does not work on the following
platforms:

* MacOS with Apple Silicon CPU
* Native Qubes OS

For this reason, we need to:

1. Disable it on the GUI side, by not allowing the user to select these
   files.
2. Throw an error on the isolation provider side, in case the user
   directly attempts to convert the file (either through CLI or via
   "Open With").

Refs #494
Refs #498
apyrgio added a commit that referenced this issue Aug 3, 2023
The HWP / HWPX conversion feature does not work on the following
platforms:

* MacOS with Apple Silicon CPU
* Native Qubes OS

For this reason, we need to:

1. Disable it on the GUI side, by not allowing the user to select these
   files.
2. Throw an error on the isolation provider side, in case the user
   directly attempts to convert the file (either through CLI or via
   "Open With").

Refs #494
Refs #498
deeplow pushed a commit that referenced this issue Aug 5, 2023
The HWP / HWPX conversion feature does not work on the following
platforms:

* MacOS with Apple Silicon CPU
* Native Qubes OS

For this reason, we need to:

1. Disable it on the GUI side, by not allowing the user to select these
   files.
2. Throw an error on the isolation provider side, in case the user
   directly attempts to convert the file (either through CLI or via
   "Open With").

Refs #494
Refs #498
@apyrgio apyrgio modified the milestones: 0.5.0, 0.6.0 Aug 28, 2023
apyrgio added a commit that referenced this issue Sep 6, 2023
This PR reverts the patch that disables HWP / HWPX conversion on MacOS
M1. It does not fix conversion on Qubes OS (#494)

Previously, HWP / HWPX conversion didn't work on MacOS M1 systems (#498)
because libreoffice wasn't built with Java support on Alpine Linux for
ARM (aarch64).

Gratefully, the Alpine team has enabled Java support on the aarch64
system [1], so we can enable it again for ARM architectures.

Fixes #498

[1]: https://gitlab.alpinelinux.org/alpine/aports/-/commit/74d443f479df15fc57e6fde6ac02a36b24afdded
@apyrgio apyrgio modified the milestones: 0.6.0, Bookmarks Nov 22, 2023
OctopusET added a commit to OctopusET/dangerzone that referenced this issue Dec 8, 2023
This PR reverts the patch that disables HWP / HWPX conversion on MacOS M1.
It does not fix conversion on Qubes OS. freedomofpress#494

Previously, HWP / HWPX conversion didn't work on MacOS (Apple silicon CPU). freedomofpress#498
because libreoffice wasn't built with Java support on Alpine Linux for ARM (aarch64).

Gratefully, the Alpine team has enabled Java support on the aarch64
system [1], so we can enable it again for ARM architectures.
And this patch is included in Alpine 3.19

This commit was included in freedomofpress#541 and reverted on freedomofpress#562 due to a stability issue.

Fixes freedomofpress#498

[1]: https://gitlab.alpinelinux.org/alpine/aports/-/commit/74d443f479df15fc57e6fde6ac02a36b24afdded
apyrgio pushed a commit to OctopusET/dangerzone that referenced this issue Dec 13, 2023
This PR reverts the patch that disables HWP / HWPX conversion on MacOS M1.
It does not fix conversion on Qubes OS (freedomofpress#494).

Previously, HWP / HWPX conversion didn't work on MacOS (Apple silicon CPU) (freedomofpress#498)
because libreoffice wasn't built with Java support on Alpine Linux for ARM (aarch64).

Gratefully, the Alpine team has enabled Java support on the aarch64
system [1], so we can enable it again for ARM architectures.
And this patch is included in Alpine 3.19

This commit was included in freedomofpress#541 and reverted on freedomofpress#562 due to a stability issue.

Fixes freedomofpress#498

[1]: https://gitlab.alpinelinux.org/alpine/aports/-/commit/74d443f479df15fc57e6fde6ac02a36b24afdded
apyrgio pushed a commit to OctopusET/dangerzone that referenced this issue Dec 13, 2023
This PR reverts the patch that disables HWP / HWPX conversion on MacOS M1.
It does not fix conversion on Qubes OS (freedomofpress#494).

Previously, HWP / HWPX conversion didn't work on MacOS (Apple silicon CPU) (freedomofpress#498)
because libreoffice wasn't built with Java support on Alpine Linux for ARM (aarch64).

Gratefully, the Alpine team has enabled Java support on the aarch64
system [1], so we can enable it again for ARM architectures.
And this patch is included in Alpine 3.19

This commit was included in freedomofpress#541 and reverted on freedomofpress#562 due to a stability issue.

Fixes freedomofpress#498

[1]: https://gitlab.alpinelinux.org/alpine/aports/-/commit/74d443f479df15fc57e6fde6ac02a36b24afdded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants