Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Qt6 before Qt5 end-of-life #1562

Closed
eloquence opened this issue Sep 16, 2022 · 6 comments
Closed

Migrate to Qt6 before Qt5 end-of-life #1562

eloquence opened this issue Sep 16, 2022 · 6 comments

Comments

@eloquence
Copy link
Member

eloquence commented Sep 16, 2022

Description

According to Qt, Qt 5.15 will reach EOL on 2023-05-26 for non-subscribers. We should ensure we migrate to a supported version before then.

@eloquence
Copy link
Member Author

A couple of notes:

  • There's https://community.kde.org/Qt5PatchCollection but it's not clear to me if the Debian project merges these patches consistently. If they do, this may be less of an issue.
  • Since we're relying on system packages in our Debian Bullseye VM, if I understand correctly, we may be hitting the EOL date for Qt 5.15 before Debian Bookworm is available. If so, this migration might entail shipping a supported version of Qt with the SecureDrop Client.

@gonzalo-bulnes
Copy link
Contributor

Fantastic, this lines up nicely with questions I have for @creviera in #1555.

@legoktm
Copy link
Member

legoktm commented Sep 21, 2022

Do we have any indication that Debian is not fixing Qt security issues, even after upstream EOL? https://security-tracker.debian.org/tracker/source-package/qtbase-opensource-src looks good to me.

I don't see qt listed in https://salsa.debian.org/debian/debian-security-support/-/blob/master/security-support-ended.deb9 or https://salsa.debian.org/debian/debian-security-support/-/blob/master/security-support-ended.deb10 which leads me to believe it should be fine (I can ask the Debian Security Team member I know if we're still concerned).

The one caveat is that qt-webkit/qt-webengine are listed in https://salsa.debian.org/debian/debian-security-support/-/blob/master/security-support-limited - but I assume(d) we're not using those?

@eloquence
Copy link
Member Author

Since the EOL deadline is approaching, I think it would be good to have clarity on Debian's approach to security issues after the upstream EOL date. If nothing forces us to migrate, we could potentially defer it until the Bookworm migration.

@gonzalo-bulnes
Copy link
Contributor

Yes, and, I think that https://github.com/freedomofpress/securedrop-engineering/pull/21 (private link, sorry folks) is also a reason to defer this migration until the last responsible moment.

@legoktm
Copy link
Member

legoktm commented Mar 10, 2023

Moritz of the Debian security team confirmed that Qt gets full security support (except for qt-webkit) and "it's also fairly robust, security issues have been fairly obscure in general: https://security-tracker.debian.org/tracker/source-package/qtbase-opensource-src"

So I'd suggest we close this and deal with the upgrade as part of bookworm or other work.

@legoktm legoktm closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants