Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update application tests to run under Python 3 #188

Closed
zenmonkeykstop opened this issue Nov 2, 2018 · 1 comment · Fixed by #201
Closed

Update application tests to run under Python 3 #188

zenmonkeykstop opened this issue Nov 2, 2018 · 1 comment · Fixed by #201

Comments

@zenmonkeykstop
Copy link
Contributor

The configuration tests under '/tests' are written for Python2.
On dom0, compare the results of

make test

and

python3 -m unittest discover tests

The tests should be updated to run under Python3, and the Makefile targets should use Python3 explicitly.

@conorsch
Copy link
Contributor

conorsch commented Nov 9, 2018

Took a look at this while builds were running; the diff is quite small to update the config tests (as usual, update string handling to use .decode("utf-8") where appropriate). Will submit as part of another PR later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants