Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host dh-virtualenv package on apt.freedom.press instead of pinning it from impish #6410

Closed
legoktm opened this issue Apr 22, 2022 · 1 comment

Comments

@legoktm
Copy link
Member

legoktm commented Apr 22, 2022

Description

dh-virtualenv isn't available in focal. In the builder we pull it from impish with:

# TEMPORARY: install dh-virtualenv from unstable Ubuntu release, pending focal package:
# https://github.com/spotify/dh-virtualenv/issues/298
RUN echo "deb http://archive.ubuntu.com/ubuntu/ impish universe main" > /etc/apt/sources.list.d/ubuntu-impish.list
COPY dh-virtualenv.pref /etc/apt/preferences.d/

RUN apt-get update && apt-get install -y dh-virtualenv

Instead of this kind of hack that needs to rely on pinning to only take this from impish, we can create a component on apt.freedom.press called "builddeps" (or backports, or ...), copy dh-virtualenv there, and add that source to the builder (with some bootstrapping of the securedrop-keyring fun).

Motivation

  • At some point in the near? future Ubuntu will archive Impish, so we'll need to update the URL or mirror it anyways. And maybe at the same time or at a different point in time, the signatures on Impish's Release files will expire, causing other issues. Would be nice to just get head of all of that.
  • Also, the current setup is a bit icky :v
@legoktm
Copy link
Member Author

legoktm commented Nov 2, 2022

I think #6538 (Drop dh-virtualenv) is a better direction to go in.

@legoktm legoktm closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant