Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker build and push to GitHub actions #2116

Closed
flooie opened this issue Jun 10, 2022 · 10 comments
Closed

Add docker build and push to GitHub actions #2116

flooie opened this issue Jun 10, 2022 · 10 comments

Comments

@flooie
Copy link
Contributor

flooie commented Jun 10, 2022

@mlissner

I may be wrong but I think we already push docker images (occasionally to docker hub from GitHub actions).

I think we should be able to add a tag v0.0.0 trigger to a GitHub CI and push our production images.

@mlissner
Copy link
Member

I don't think we push currently. We run a docker hub clone in the CI and we push to that, I think.

@flooie
Copy link
Contributor Author

flooie commented Jun 10, 2022

Yeah, I just remembered that, but we can still do the build and push for everything still

@mlissner
Copy link
Member

Yes. I think we can also ask docker hub to do the build. I'm not sure the pros/cons of the different approaches. If pushing from CI takes time, it's probably not worth doing it, though it might not take much time if I remember correctly. I forget how docker hub works.

@flooie
Copy link
Contributor Author

flooie commented Jun 10, 2022

@flooie
Copy link
Contributor Author

flooie commented Jun 10, 2022

I assumed that since the image built on GitHub ci is web-dev and its labeled push it might be us pushing it every time. or atleast every time you push to main.

@mlissner
Copy link
Member

Ah, I see. No, the makefile pushes those now because new devs were having to build an image just to get started, or else they pulled an ancient image and suffered.

@flooie
Copy link
Contributor Author

flooie commented Jul 27, 2022

Re-opening this image because GitHub actions for building developer images and pushing to docker hub is failing.

@mlissner
Copy link
Member

I saw that. Looked ARM related, I'm sorry to say. I was hoping it'd fix itself in a day or two when debian folks fix whatever sub-dependency broke.

@mlissner
Copy link
Member

mlissner commented Aug 9, 2022

Alas, this problem still keeps happening. Shoot.

Some clues here, but it seems like it's a buildx issue related to arm:

docker/buildx#495

Bleh. I kind of still hope it fixes itself, but we don't have dev images in the meantime.

@mlissner
Copy link
Member

mlissner commented Aug 9, 2022

Seems to be fixed via docker/buildx#495 (comment)

Disappointing stuff, Docker.

@mlissner mlissner closed this as completed Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants