-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker build and push to GitHub actions #2116
Comments
I don't think we push currently. We run a docker hub clone in the CI and we push to that, I think. |
Yeah, I just remembered that, but we can still do the build and push for everything still |
Yes. I think we can also ask docker hub to do the build. I'm not sure the pros/cons of the different approaches. If pushing from CI takes time, it's probably not worth doing it, though it might not take much time if I remember correctly. I forget how docker hub works. |
You have a web-dev build on docker hub that made me think that these images were actually pushing |
I assumed that since the image built on GitHub ci is web-dev and its labeled push it might be us pushing it every time. or atleast every time you push to main. |
Ah, I see. No, the makefile pushes those now because new devs were having to build an image just to get started, or else they pulled an ancient image and suffered. |
Re-opening this image because GitHub actions for building developer images and pushing to docker hub is failing. |
I saw that. Looked ARM related, I'm sorry to say. I was hoping it'd fix itself in a day or two when debian folks fix whatever sub-dependency broke. |
Alas, this problem still keeps happening. Shoot. Some clues here, but it seems like it's a buildx issue related to arm: Bleh. I kind of still hope it fixes itself, but we don't have dev images in the meantime. |
Seems to be fixed via docker/buildx#495 (comment) Disappointing stuff, Docker. |
@mlissner
I may be wrong but I think we already push docker images (occasionally to docker hub from GitHub actions).
I think we should be able to add a tag v0.0.0 trigger to a GitHub CI and push our production images.
The text was updated successfully, but these errors were encountered: