Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rod recasts randomly #6

Open
MrWarHawkk opened this issue Jan 10, 2018 · 13 comments
Open

Rod recasts randomly #6

MrWarHawkk opened this issue Jan 10, 2018 · 13 comments

Comments

@MrWarHawkk
Copy link

MrWarHawkk commented Jan 10, 2018

When I cast the rod in it randomly recasts. This is not due to clearlag, it happens around 30-45 secs after casting.

@freneticfeline
Copy link
Owner

freneticfeline commented Jan 15, 2018

What version of Minecraft are you using? Also, are there any messages in the Minecraft Game Output log when it happens? Finally, do you have the "Enable Aggressive Bite Detection" option set to true?

@MrWarHawkk
Copy link
Author

I use 1.8.9 which is my prefered version, so if there is a fix for it on that version it'd be great. I'm not too sure what the "Minecraft Game Output Log" is unless it's the logs in my .minecraft. In those logs, I do see this message about the mod "[19:08:31] [Client thread/WARN]: Mod mod_autofish is missing the required element 'version' and a version.properties file could not be found. Falling back to metadata version 1.8.9-1.7". Not sure if that helps or not

@freneticfeline
Copy link
Owner

freneticfeline commented Jan 15, 2018

The accuracy of my mod decreases going back with Minecraft versions, and 1.8.9 is the earliest version I am supporting, if that tells you anything. My best guess is that it thinks there is a bite when there isn't. How often does this happen? And what options do you have enabled?

Your Minecraft launcher should have an option somewhere to "Keep launcher open" when you start the game. You will be able to see the log output there. I think that's the same thing that gets written to .minecraft. If there is something written there when it recasts, it might help me figure out what is causing it. (Logs from my mod will include the text "[AutoFish]:".)

@MrWarHawkk
Copy link
Author

It happens like every 3-10 secs.
I only have the autofish option enabled, I've tried having all options on, it still happens
I'll do the launcher thing now.

@MrWarHawkk
Copy link
Author

MrWarHawkk commented Jan 15, 2018

This is all that it comes up with when it recasts the rod.

"Client thread | warn | Unable to play unknown soundEvent: minecraft:entity.bobber.retrieve"

@freneticfeline
Copy link
Owner

Please try this debug build of the mod (remove the JAR file that is currently installed, and double-check in the Mod Info screen that the version number is 1.8.9-1.7-debug). This one should output additional logging information when you are fishing. Let it go for a few minutes (at least 10 casts), and then send me the logfile. Hopefully I'll be able to figure something out from that.

https://github.com/freneticfeline/mod_autofish/releases/download/v1.8.9-1.7-debug/mod_autofish_forge-1.8.9-1.7-debug.jar

@MrWarHawkk
Copy link
Author

I will do it tomorrow when I get on mc, thanks for the help :D

@MrWarHawkk
Copy link
Author

latest.log

Those should be the logs from when I was fishing.

@freneticfeline
Copy link
Owner

Thanks, that is very helpful. The bite detection seems to be too aggressive for you. I will try to tweak it, though it is hard to find the right balance. (For me, if I make it less aggressive I miss a lot of fish.) Once I find something that I think will work, I'll give you another build to test.

@MrWarHawkk
Copy link
Author

That's great, Thanks :D

@freneticfeline
Copy link
Owner

OK, please try out this build. Hopefully it won't reel in too early as often. However, for me it misses more fish. If it also misses fish for you, try the "Enable Aggressive Bite Detection" option and see how that works for you. If you still have problems, please provide a log file like you did before.

https://github.com/freneticfeline/mod_autofish/releases/download/v1.8.9-1.7-debug/mod_autofish_forge-1.8.9-1.7-debug2.jar

@MrWarHawkk
Copy link
Author

I just used the one you sent me, it's a lot better with less random reeling. However, it still occasionally reels in when it's not meant to. I was wondering if it would be possible if you could add in an option for the user to change the bite detection, not sure if that's possible or not.
latest.log

@MrWarHawkk
Copy link
Author

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants