Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerations are not passed from the StatefulSet to pods when adding storage definition #11

Open
rotemjac opened this issue Nov 23, 2024 · 1 comment

Comments

@rotemjac
Copy link

rotemjac commented Nov 23, 2024

Expected behaviour

I want to use tolerations AND storage class settings.

Actual behaviour

Tolerations are not passed from the StatefulSet to the pods when adding storage definition.

This is working:

  redis:
    replicas: {{ .Values.Redis.Replicas }}
    tolerations:
      - key: "node/{{ .Values.Redis.Node.TaintKey }}"
        operator: "Exists"
        effect: "NoSchedule"
      - key: "node/{{ .Values.Redis.Node.TaintKey }}"
        operator: "Exists"
        effect: "NoExecute"

This is not:

  redis:
    storage:
      persistentVolumeClaim:
        metadata:
          name: redisfailover-persistent
        spec:
          accessModes:
            - ReadWriteOnce
          resources:
            requests:
              storage: 0.2Gi
          storageClassName: st1
    replicas: {{ .Values.Redis.Replicas }}
    tolerations:
      - key: "node/{{ .Values.Redis.Node.TaintKey }}"
        operator: "Exists"
        effect: "NoSchedule"
      - key: "node/{{ .Values.Redis.Node.TaintKey }}"
        operator: "Exists"
        effect: "NoExecute"

Steps to reproduce the behaviour

Combine Storage definition with Tolerations - like I showed above.

Environment

How are the pieces configured?

  • Redis Operator version: 3.2.9
  • Kubernetes version: 1.31
@samof76
Copy link
Collaborator

samof76 commented Dec 5, 2024

Sure will test this and pick this up. But we do welcome if there is a PR from you on this.

BTW what does, Redis Operator version: 3.2.9, mean?

@samof76 samof76 pinned this issue Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants