Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupRowsBy "Age" works incorrectly work titanic dataset #253

Closed
ntr opened this issue Jul 25, 2014 · 2 comments
Closed

GroupRowsBy "Age" works incorrectly work titanic dataset #253

ntr opened this issue Jul 25, 2014 · 2 comments

Comments

@ntr
Copy link

ntr commented Jul 25, 2014

I am using following code for kaggle titanic dataset:

let titanic = Frame.ReadCsv("c:\\tmp\\titanic.csv")
let byAge = titanic.GroupRowsBy<int>("Age")

And it produces some unexpected results - age in rows keys does not match age in rows values:

titanicissue

I suspect this issue takes place because some age values are missing because this code works correctly:

titanic.DropSparseRows().GroupRowsBy<int>("Age")
@sebhofer
Copy link

sebhofer commented Mar 8, 2018

I discovered the same behaviour. MWE:

//expected behaviour
Frame.ofValues [ (1,"foo","a"); (1,"bar","b");  (3,"foo","d"); (3,"bar","e"); (4,"bar","f")]
|> Frame.groupRowsByString "bar"

//unexpected behaviour
Frame.ofValues [ (1,"foo","a"); (1,"bar","b"); (2,"foo","c"); (3,"foo","d"); (3,"bar","e"); (4,"bar","f")]
|> Frame.groupRowsByString "bar"

@sebhofer
Copy link

sebhofer commented Aug 7, 2018

Fixed by #405

@zyzhu zyzhu closed this as completed Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants