Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages on nuget #392

Closed
dsyme opened this issue Jul 18, 2018 · 16 comments
Closed

Update packages on nuget #392

dsyme opened this issue Jul 18, 2018 · 16 comments
Assignees

Comments

@dsyme
Copy link
Member

dsyme commented Jul 18, 2018

@tpetricek We will need to update the Deedle packages on nuget. Could you give access to @zyzhu and myself? thanks

@hickford
Copy link

hickford commented Jul 18, 2018

@zyzhu
Copy link
Contributor

zyzhu commented Jul 27, 2018

@tpetricek, I've just registered on nuget with the same username zyzhu. Please asign access. Thanks.

@drobertson123
Copy link

Is this release going to be more compatible with .NET core?

Any idea when it will be pushed? At this point I just see ver 1.2.5 from June 6th, 2016.

Thanks

@zyzhu
Copy link
Contributor

zyzhu commented Jul 31, 2018

@dsyme I saw you are already the owner of Deedle on nuget. Would you like to take a look at nuspec and release a newer version of Deedle targeting both netstandard2.0 and net45? We can always fix other issues one at a time.

@drobertson123
Copy link

Targeting netstandard would be very helpful. I was considering branching and changing the project locally just for this.
I am using .NET core 2.0/2.1 so I think netstandard would get me by all the warnings I am seeing

warning NU1701: Package 'Deedle 1.2.5' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.1'. This package may not be fully compatible with your project.

A new version would be a far better solution.

@dsyme
Copy link
Member Author

dsyme commented Aug 2, 2018

@zyzhu You are now owners, except not of https://www.nuget.org/packages/Deedle.RPlugin/, since I am not owner of that. @tpetricek can help

@dsyme
Copy link
Member Author

dsyme commented Aug 4, 2018

@zyzhu Are you all ready to update the packages on nuget? I think you might still need access to Deedle.RProvider?

It would be great to get the .NET Standard packages pushed

@kblohm
Copy link
Contributor

kblohm commented Aug 4, 2018

It is maybe not super important, but maybe someone else can have a look at the RPlugin ? I did not manage to get that to work properly and right now it is just copying assemblies instead of using paket for the dependency on the RPlugin. If i change that back to using paket, i still get the same error i described in the original PR ( #382). Maybe that is a super simple problem and i just have no idea how to fix it, maybe it is not important at all. But i think it would be nice if someone could have another look before that package gets updated on nuget.

@kblohm
Copy link
Contributor

kblohm commented Aug 4, 2018

Two more things:

  • The release-notes should probably be updated
  • Maybe it is worth to update the version to 2.0.0-beta or some other beta-version? At least if there are more changes planned now that the project is getting active again, that way it is "easier" to make breaking changes if they are needed

@kblohm
Copy link
Contributor

kblohm commented Aug 4, 2018

I updated the version and release notes in #400

@zyzhu
Copy link
Contributor

zyzhu commented Aug 4, 2018

I've published Deedle and Deedle.Excel to nuget. Unfortunately the logo url of Deedle was wrong. Newbie mistake. We can update it in the next beta release. Thanks for everybody's help!

As for Deedle.RPlugin, we need to test more and find out why do we have to link DLL directly instead of via paket/nuget.

@grisharav
Copy link

Any plans to release an official (not beta) nuget package for Deedle with support for .net standard?

@kblohm
Copy link
Contributor

kblohm commented Aug 27, 2018

As deedle is just getting attention again i would not really advice in releasing a none-beta version too early as that does make breaking changes a lot harder. Is there any problem in using the beta version?

@grisharav
Copy link

If our project is dependent on the Deedle beta package, it forces all our releases to be prerelease packages as well. See https://github.com/NuGet/docs.microsoft.com-nuget/blob/master/docs/reference/errors-and-warnings/NU5104.md, this is problematic for us.

@grisharav
Copy link

Actually, I saw it's a warning in newer dotnet versions, so it is probably OK to use it as beta.

@zyzhu
Copy link
Contributor

zyzhu commented Mar 14, 2019

Close this as Deedle 2.0.0 has been released.

@zyzhu zyzhu closed this as completed Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants