Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature of Matrix.dot is unnecessarily limited #536

Closed
brianberns opened this issue Aug 31, 2021 · 3 comments
Closed

Signature of Matrix.dot is unnecessarily limited #536

brianberns opened this issue Aug 31, 2021 · 3 comments

Comments

@brianberns
Copy link

The current signature of Matrix.dot for two frames is:

df1:Frame<'R, 'C> * df2:Frame<'C, 'R> -> Frame<'R,'R>

But why do the 'R types have to match? This seems to be more flexible and make more sense:

df1:Frame<'R0, 'C> * df2:Frame<'C, 'R1> -> Frame<'R0,'R1>
@zyzhu
Copy link
Contributor

zyzhu commented Aug 31, 2021

That's a good point. I've fixed it here e1e1a0c and released Deedle.Math 2.4.2.

@zyzhu zyzhu closed this as completed Aug 31, 2021
@brianberns
Copy link
Author

Thanks for making this change, but it looks like Deedle.Math 2.4.2 refers to Deedle 2.4.2, which hasn't been released yet. Is that on the way as well?

@zyzhu
Copy link
Contributor

zyzhu commented Aug 31, 2021

They should be on Nuget now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants