Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is failing on appVeyor with a sourcelink error #810

Closed
ovatsus opened this issue Mar 29, 2015 · 5 comments
Closed

Build is failing on appVeyor with a sourcelink error #810

ovatsus opened this issue Mar 29, 2015 · 5 comments

Comments

@ovatsus
Copy link

ovatsus commented Mar 29, 2015

No description provided.

@ovatsus
Copy link
Author

ovatsus commented Mar 29, 2015

@ctaggart could you have a look? It's complaining about the FSharp.Data.Portable7.fsproj, but earlier on the script that was built without problems. I think the problem is that the VisualStudio variable is being evaluated incorrectly inside the sourcelink script

@ctaggart
Copy link
Contributor

Yes, I'll have a look.

@ctaggart
Copy link
Contributor

So i see the latest build failed.
https://ci.appveyor.com/project/ovatsus/fsharp-data

image

This got updated:
https://github.com/fsharp/FSharp.Data/blame/master/src/FSharp.Data.Portable7.fsproj#L85

<Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.Portable.FSharp.Targets" />

See ctaggart/SourceLink#50 for the best solution at the moment.

//        let p = VsProj.LoadRelease proj
        let p = VsProj.Load proj ["Configuration","Release"; "VisualStudioVersion","12.0"]

ovatsus pushed a commit that referenced this issue Mar 29, 2015
@ovatsus
Copy link
Author

ovatsus commented Mar 29, 2015

Thanks, I'm trying that

@ovatsus
Copy link
Author

ovatsus commented Mar 29, 2015

Problem fixed. Thanks for your help!

@ovatsus ovatsus closed this as completed Mar 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants