Add support for ValueTuple #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusty
reviewed
Nov 24, 2022
gusty
reviewed
Nov 24, 2022
rodriguestiago0
commented
Nov 24, 2022
gusty
reviewed
Nov 24, 2022
| @@ -42,6 +42,7 @@ From .Net/F# | |||
| - ``Map<'T,'U>`` | |||
| - ``TimeSpan`` | |||
| - ``Tuple<*>`` | |||
| - ``ValueTuple<*>`` | |||
There was a problem hiding this comment.
This is tricky. either we support ValueTuple<n> with n < 8 or we do some kind of reflection trick for those tuples greater than 8.
There was a problem hiding this comment.
we support for n >= 0 and n <= 8
There was a problem hiding this comment.
Should I remove this line?
There was a problem hiding this comment.
No, in that case just change it to ValueTuple<*> (* up to 8 elements)
…igues/valueTupple
This reverts commit 5084858.
gusty
force-pushed
the
rodrigues/valueTupple
branch
from
9af5645 to
7b50816
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.