Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image is not updated #249

Open
IvanAntipov opened this issue Mar 16, 2020 · 5 comments
Open

Docker image is not updated #249

IvanAntipov opened this issue Mar 16, 2020 · 5 comments

Comments

@IvanAntipov
Copy link

Description

Docker image of IfSharp

https://hub.docker.com/r/fsprojects/ifsharp

Updated a year ago

Could you update this image, please.

@cgravill
Copy link
Member

cgravill commented Jun 4, 2020

Sounds good, if someone wants to update the Docker image that's most welcome.

@stephen-swensen
Copy link

I've spent a few hours trying to get the Docker image to build locally with no luck. I won't detail the errors because it's just been a game a wack-a-mole. Perhaps someone more knowledgeable with this project could audit the Dockerfile build and get it back into shape, it seems to have suffered from general code rot (docker builds are not always as reproducible as you might hope, breaking changes to externally pulled dependencies can creep in).

@stephen-swensen
Copy link

^ sorry if the above sounded rude - I didn't mean it to be :)

@cgravill
Copy link
Member

cgravill commented Jun 5, 2020

No problem @stephen-swensen and thanks for giving a go. There have been occasional contributions to the Docker image but it's not heavily used, and I personally don't use it at all, so getting out sync with upstream dependencies makes sense. Fixes for this would be welcome from anyone who can manage it!

@jhgoodwin
Copy link

I made a version which builds for netcore, though I didn't update the mono one.

https://github.com/jhgoodwin/IfSharp/tree/features/add_netcore_dockerfile

The intellisense is broken in mine, which I think is due to 0 opened comms messages in the /notebooks/shell.log

I built it like this:

docker build -f netcore.Dockerfile -t jhgoodwin/ifsharp:dev .

Note my version uses the current source to build instead of using git and pulling down external sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants