Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression in type signature of UPath.rename #257

Closed
ap-- opened this issue Aug 27, 2024 · 1 comment · Fixed by #258
Closed

regression in type signature of UPath.rename #257

ap-- opened this issue Aug 27, 2024 · 1 comment · Fixed by #258
Assignees
@ap--
Labels
bug 🐛 Something isn't working

Comments

@ap--
Copy link
Collaborator

ap-- commented Aug 27, 2024

with the release of v0.2.3 commit 93855d2 introduced a regression in the type signature of UPath.rename, causing mypy to complain. see: apache/airflow#41723
@ap-- ap-- added the bug 🐛 Something isn't working label Aug 27, 2024
@ap-- ap-- self-assigned this Aug 27, 2024
@ap--
Copy link
Collaborator Author

ap-- commented Aug 27, 2024

We'd need https://peps.python.org/pep-0728/ to type this correctly via TypedDicts. Need to introduce a unset default value for maxdepth and recursive to get this working as intended.

@ap-- ap-- mentioned this issue Aug 27, 2024
Merged
@ap-- ap-- closed this as completed in #258 Aug 27, 2024
@ap-- ap-- mentioned this issue Aug 28, 2024
Merged
@potiuk potiuk mentioned this issue Aug 28, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ap-- ap--

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix UPath.rename type signature ap--/universal_pathlib
1 participant
@ap--