Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Auth Module: Bring methods in-line & add missing methods #118

Closed
11 tasks done
Ehesp opened this issue Nov 8, 2016 · 3 comments
Closed
11 tasks done

[v3] Auth Module: Bring methods in-line & add missing methods #118

Ehesp opened this issue Nov 8, 2016 · 3 comments
Milestone

Comments

@Ehesp
Copy link
Contributor

Ehesp commented Nov 8, 2016

Currently working through the auth docs on my own fork, there's some differences between the Firestack methods vs the JS method names. I believe it should mimic the Firebase API as close as possible, since most users will reference their docs on how to do certain things, it'd make it easy to come straight to the same method here.

Also some methods are missing:

Differences:

Missing:

Not working

  • signOut
    • Returns ok but doesn't sign out.
  • signIn with disabled account(all?)
    • Crashes the app on boot.
@auser
Copy link
Contributor

auser commented Nov 8, 2016

At this point, I think we need to create a deprecated helper that logs out deprecated warnings about using these methods and rename the methods to match their firebase js counterparts. Want to take a crack at that?

@Ehesp
Copy link
Contributor Author

Ehesp commented Nov 8, 2016

Sure, would a console.warn suffice?

@auser
Copy link
Contributor

auser commented Nov 9, 2016

Yep, definitely would.

@Salakar Salakar changed the title Auth Module: Bring methods in-line & add missing methods [v3] Auth Module: Bring methods in-line & add missing methods Nov 19, 2016
@Salakar Salakar added this to the v3 milestone Nov 19, 2016
@Ehesp Ehesp closed this as completed Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants