Update output documentation #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limemloh
reviewed
Dec 16, 2018
README.md
Outdated
| things simple). | ||
|
|
||
| ```ts | ||
| Component<{}, { value: Behavior<string>, click: Stream<ClickEvent>, ... } |
limemloh
reviewed
Dec 16, 2018
README.md
Outdated
| event listeners in other frameworks. However, there are fundamental | ||
| differences between the two things. If you are familiar with how | ||
| asynchronous functions that takes callbacks differ from asynchronous | ||
| function that returns promises then the following analogy make help |
There was a problem hiding this comment.
the following analogy make help
I assume you mean to write:
the following analogy may help
limemloh
reviewed
Dec 16, 2018
README.md
Outdated
| * A button outputs, among other things, a stream of click events. So | ||
| part of its output is a stream of the type `Stream<ClickEvent>>`. | ||
| * An input box's output includes a behavior of the text inside the | ||
| input. The type would be `Behavior<string>`. | ||
| * A checkbox might output a behavior representing wether it is checked |
There was a problem hiding this comment.
I guess that is actually an old typo, but should still be fixed 😄
paldepind
force-pushed
the
update-output-documentation
branch
from
3d340e5
to
0bc6f88
Compare
|
Thanks @limemloh 😄 I've fixed the typos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation is pretty outdated with regards to how output works. This is improves the situation somewhat.