Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyclic include in norm.hpp/quaternion.hpp #1259

Closed
DctrNoob opened this issue Feb 15, 2024 · 0 comments · Fixed by #1273
Closed

Cyclic include in norm.hpp/quaternion.hpp #1259

DctrNoob opened this issue Feb 15, 2024 · 0 comments · Fixed by #1273

Comments

@DctrNoob
Copy link

A clang-tidy analysis warned me that there's a cyclic include in norm.hpp/quaternion.hpp which is true. norm.hpp has #include "../gtx/quaternion.hpp" while quaternion.hpp has #include "../gtx/norm.hpp".

I don't quiet understand why norm.hpp needs to include the quaternion header so I suspect the include should be removed there though I don't understand the codebase too well to make the final call and raise a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants