Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): add support for react - initial dev #11

Merged
merged 20 commits into from
Sep 18, 2018
Merged

Conversation

GabeDuarteM
Copy link
Owner

@GabeDuarteM GabeDuarteM commented Sep 14, 2018

Still need some adjustments, but the basic dev workflow is working

closes #10

@GabeDuarteM GabeDuarteM self-assigned this Sep 14, 2018
@GabeDuarteM GabeDuarteM mentioned this pull request Sep 14, 2018
@GabeDuarteM GabeDuarteM force-pushed the feat/react branch 2 times, most recently from 4dee04d to e6874ec Compare September 16, 2018 22:59
Still need some adjustments, but the basic dev workflow is working
* Now it is checked if the following files are present: `public/index.html` or one of the following`src/index.tsx` or `src/index.js`. If one of them is missing, it should throw and stop the build
* Start of the prod build (added just the stubs, but the config is still the same as the dev one)
Use the same overlay that create-react-app uses 😁
It was being problematic on the published package (was fine on local dev though 🤷‍♂️)
Apparently, it no longer errors when not installed.
User-suplied babel config must be a `.babel.js` file.
@GabeDuarteM GabeDuarteM removed the wip label Sep 18, 2018
@GabeDuarteM GabeDuarteM merged commit 5976488 into master Sep 18, 2018
@GabeDuarteM GabeDuarteM deleted the feat/react branch September 18, 2018 07:42
@GabeDuarteM
Copy link
Owner Author

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support react
1 participant