-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): add support for react - initial dev #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
GabeDuarteM
force-pushed
the
feat/react
branch
2 times, most recently
from
September 16, 2018 22:59
4dee04d
to
e6874ec
Compare
Still need some adjustments, but the basic dev workflow is working
* Now it is checked if the following files are present: `public/index.html` or one of the following`src/index.tsx` or `src/index.js`. If one of them is missing, it should throw and stop the build * Start of the prod build (added just the stubs, but the config is still the same as the dev one)
Use the same overlay that create-react-app uses 😁
It was being problematic on the published package (was fine on local dev though 🤷♂️)
Apparently, it no longer errors when not installed.
User-suplied babel config must be a `.babel.js` file.
GabeDuarteM
force-pushed
the
feat/react
branch
from
September 17, 2018 20:46
354fe1d
to
df083ab
Compare
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need some adjustments, but the basic dev workflow is working
closes #10